Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support telnet for Python 3.13 #29

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Support telnet for Python 3.13 #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions logparser/telnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@
import platform
import re
import sys
from telnetlib import DO, DONT, IAC, SB, SE, Telnet, TTYPE, WILL, WONT

# DeprecationWarning: 'telnetlib' is deprecated and slated for removal in Python 3.13
try:
import telnetlib
except ImportError:
telnetlib = None

import traceback

import pexpect
Expand Down Expand Up @@ -95,7 +101,7 @@ def run(self):
self.host = self.OVERRIDE_TELNET_CONSOLE_HOST or self.host

self.logger.debug("Try to telnet to %s:%s for %s", self.host, self.port, self.data['log_path'])
if self.telnet_password:
if self.telnet_password or telnetlib is None:
self.setup_pexpect()
if self.tn is not None:
self.pexpect_io()
Expand All @@ -117,16 +123,16 @@ def setup_pexpect(self):

@staticmethod
def telnet_callback(tn, command, option):
if command == DO and option == TTYPE:
tn.sendall(IAC + WILL + TTYPE)
tn.sendall(IAC + SB + TTYPE + '\0' + 'LogParser' + IAC + SE)
elif command in (DO, DONT):
tn.sendall(IAC + WILL + option)
elif command in (WILL, WONT):
tn.sendall(IAC + DO + option)
if command == telnetlib.DO and option == telnetlib.TTYPE:
tn.sendall(telnetlib.IAC + telnetlib.WILL + telnetlib.TTYPE)
tn.sendall(telnetlib.IAC + telnetlib.SB + telnetlib.TTYPE + '\0' + 'LogParser' + telnetlib.IAC + telnetlib.SE)
elif command in (telnetlib.DO, telnetlib.DONT):
tn.sendall(telnetlib.IAC + telnetlib.WILL + option)
elif command in (telnetlib.WILL, telnetlib.WONT):
tn.sendall(telnetlib.IAC + telnetlib.DO + option)

def setup_telnet(self):
self.tn = Telnet(self.host, int(self.port), timeout=TELNET_TIMEOUT)
self.tn = telnetlib.Telnet(self.host, int(self.port), timeout=TELNET_TIMEOUT)
# [twisted] CRITICAL: Unhandled Error
# Failure: twisted.conch.telnet.OptionRefused: twisted.conch.telnet.OptionRefused
# https://github.com/jookies/jasmin-web/issues/2
Expand Down Expand Up @@ -165,11 +171,16 @@ def bytes_to_str(src):
return src.decode('utf-8')
# TypeError: got <type 'str'> ('Username: ') as pattern,
# must be one of: <type 'unicode'>, pexpect.EOF, pexpect.TIMEOUT
self.tn.expect(u'Username: ', timeout=TELNET_TIMEOUT)
self.tn.sendline(self.telnet_username)
self.tn.expect(u'Password: ', timeout=TELNET_TIMEOUT)
self.tn.sendline(self.telnet_password)
self.tn.expect(u'>>>', timeout=TELNET_TIMEOUT)
if self.telnet_password:
self.tn.expect(u'Username: ', timeout=TELNET_TIMEOUT)
self.tn.sendline(self.telnet_username)
self.tn.expect(u'Password: ', timeout=TELNET_TIMEOUT)
self.tn.sendline(self.telnet_password)
self.tn.expect(u'>>>', timeout=TELNET_TIMEOUT)
self.logger.debug("Login successfully")
else:
self.tn.expect(u'>>>', timeout=TELNET_TIMEOUT)
self.logger.debug("Connect successfully")

self.tn.sendline(bytes_to_str(TELNETCONSOLE_COMMAND_MAP['log_file']))
self.tn.expect(re.compile(r'[\'"].+>>>', re.S), timeout=TELNET_TIMEOUT)
Expand Down