Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular upgrade #55

Merged
merged 9 commits into from
May 21, 2020
Merged

Angular upgrade #55

merged 9 commits into from
May 21, 2020

Conversation

godind
Copy link
Collaborator

@godind godind commented May 19, 2020

Hi,

I'm done with the upgrade. Was not too bad actually. Mostly the issue was with @ViewChild. You now have {static: true} to have View references generated before onInit. Else Angular says Reference now found - Views, Input, etc Directives get generated AfterViewInit normally so can't use before. Also had to remove deprecated stuff... nothing major.

Ivy, new v8 View generator, is pretty snappy! Love the upgrade.

Let me know...
Thanks

@godind
Copy link
Collaborator Author

godind commented May 19, 2020

Angular CLI: 9.1.6
Node: 12.16.1
OS: win32 x64

Angular: 9.1.7
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router
Ivy Workspace: Yes

Package Version

@angular-devkit/architect 0.901.6
@angular-devkit/build-angular 0.901.6
@angular-devkit/build-optimizer 0.901.6
@angular-devkit/build-webpack 0.901.6
@angular-devkit/core 9.1.6
@angular-devkit/schematics 9.1.6
@angular/cdk 9.2.4
@angular/cli 9.1.6
@angular/http 7.2.16
@angular/material 9.2.4
@ngtools/webpack 9.1.6
@schematics/angular 9.1.6
@schematics/update 0.901.6
rxjs 6.5.5
typescript 3.8.3
webpack 4.42.0

Copy link
Owner

@mxtommy mxtommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Always annoying upgrading Angular, I've done it a few times now. I think when Kip started it was angular 4... :P but good to keep updated!

@mxtommy mxtommy merged commit 014cbbc into master May 21, 2020
@godind godind deleted the Angular-upgrade branch May 21, 2020 23:09
@godind godind restored the Angular-upgrade branch May 21, 2020 23:11
@godind
Copy link
Collaborator Author

godind commented May 21, 2020

Hi @mxtommy,

There is a MatListModule missing in App.Component. Don't know how that happened, but anyway, it will be in my next PR.

Thanks!

@godind godind deleted the Angular-upgrade branch May 21, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants