-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular upgrade #55
Angular upgrade #55
Conversation
Angular CLI: 9.1.6 Angular: 9.1.7 Package Version@angular-devkit/architect 0.901.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Always annoying upgrading Angular, I've done it a few times now. I think when Kip started it was angular 4... :P but good to keep updated!
Hi @mxtommy, There is a MatListModule missing in App.Component. Don't know how that happened, but anyway, it will be in my next PR. Thanks! |
Hi,
I'm done with the upgrade. Was not too bad actually. Mostly the issue was with
@ViewChild
. You now have{static: true}
to have View references generated before onInit. Else Angular says Reference now found - Views, Input, etc Directives get generated AfterViewInit normally so can't use before. Also had to remove deprecated stuff... nothing major.Ivy, new v8 View generator, is pretty snappy! Love the upgrade.
Let me know...
Thanks