Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - widget numerical event style change support #44

Merged

Conversation

godind
Copy link
Collaborator

@godind godind commented Apr 13, 2020

Simple addition to register to theme Observer and redraw unit and title.

@godind
Copy link
Collaborator Author

godind commented Apr 16, 2020

@mxtommy Do you plan to to merge? Don't be shy to share your comments or improvement suggestions to what I did. I'm eager to learn.

Also are you French? I am, and live in Montreal.

Thanks

@mxtommy
Copy link
Owner

mxtommy commented Apr 16, 2020

Yes will try and look it it later today :) I was born in and lived in Montreal. I'm English though know french well! A few months ago I moved to Dublin, Ireland for work, I'll eventually be back though!

@godind
Copy link
Collaborator Author

godind commented Apr 16, 2020

Note that I have some some good improvement gauge refactoring and feature additions coming. Mostly around using dynamic gauges instead of declarative and more config options and nicer layout.

@mxtommy mxtommy merged commit 7e81cd3 into mxtommy:master Apr 17, 2020
@godind godind deleted the add-widget-numerical-event-style-change-support branch April 18, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants