Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Support for SignalK User Authentication #135

Merged
merged 10 commits into from
Sep 27, 2022
Merged

Conversation

godind
Copy link
Collaborator

@godind godind commented Sep 27, 2022

Added login UI, login request type and token handling and expiration/renewal. Added a new connectionConfig configuration section invalidating config up to v8. Further refinement of console.log messages to improve troubleshooting. Also moved a few notification messages from Request Service to SignalK Config Component cleaning things up and reducing unnecessary notifications.

This PR provide a fully functional feature.

Next PR will be to add user config saving to server enabling automatic shared configuration.

@godind godind requested a review from mxtommy September 27, 2022 04:37
@godind godind self-assigned this Sep 27, 2022
Copy link
Owner

@mxtommy mxtommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@godind godind merged commit bc4ff8d into master Sep 27, 2022
@godind godind deleted the login-feature branch September 27, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants