-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 2.10.0: values jumping between sources #420
Comments
Did you notice this problem in prior versions? If you have multiple sources for the same path, Source Priority for each path needs to be configured in SK, else widgets will jump between sources as they publish values. This is as per specs. Check this and report back. Thank you |
I do use KIP for exactly one year. No prior version had jumping values.
Simplest example: engine hours of port and starboard engine, both displays/value do jump now (as well as RPM, fuel rate, load, voltages, amps, temps...)
Let's say: all configured instrument pages do have lot's of jumping values.
Kip is not usable any more since updating to 2.10.0
Pls check!
…________________________________
Von: David G ***@***.***>
Gesendet: Mittwoch, 29. Mai 2024 16:40
An: mxtommy/Kip
Cc: Joerg R. Plaschka; Author
Betreff: Re: [mxtommy/Kip] Update 2.10.0: values jumping between sources (Issue #420)
Did you notice this problem in prior versions?
If you have multiple sources for the same path, Source Priority for each path needs to be configured in SK, else widgets will jump between sources as they publish values. This is as per specs.
Check this and report back.
Thank you
—
Reply to this email directly, view it on GitHub<#420 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCGJ4N4MTFSUW57SJBMK4ZDZEXZGVAVCNFSM6AAAAABIOVIDIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXG4YTSNJVGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I do not agree on this logic:
The attached screenshot shows ONE selected path in the field "Signal K path" and ONE selected source from multiple sources in the field "Data source".
In my understanding this is a 1:1 definition and not 1:any (1:the last as of my observation)
Pls check the screenshot
…________________________________
Von: David G ***@***.***>
Gesendet: Mittwoch, 29. Mai 2024 16:40
An: mxtommy/Kip
Cc: Joerg R. Plaschka; Author
Betreff: Re: [mxtommy/Kip] Update 2.10.0: values jumping between sources (Issue #420)
Did you notice this problem in prior versions?
If you have multiple sources for the same path, Source Priority for each path needs to be configured in SK, else widgets will jump between sources as they publish values. This is as per specs.
Check this and report back.
Thank you
—
Reply to this email directly, view it on GitHub<#420 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCGJ4N4MTFSUW57SJBMK4ZDZEXZGVAVCNFSM6AAAAABIOVIDIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXG4YTSNJVGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I see 8 different sources for path electrical.batteries.0.voltage They appear to be for different batteries. If it's the case, you should configure one path for each battery instead of multiple sources for the same device (path).
I'm not saying there is no bug yet, but it's not good practice. Multiple Sources are meant to be used as backup providers for the same path. Like if you have 2 gps. Use gps-1 and if it's stops sending data or breaks down, use gps-2 so the path still gets the info. For this to work, you have to configure Source Priority in Signal K. Can you share a screenshot of the volt gauge configuration please. |
Yes, there are multiple sources on lots of paths, not just for electrical.batteries.0.voltage.
For the two engines it's the same method.
And the paths and sources are not defined by myself: I'm using SK on a Victron CerboGX. So the paths and sources are predefined and no changes can be done as every update from Victron will overwrite it.
Once again: no problem up to and incl. V2.9.3.
…________________________________
Von: David G ***@***.***>
Gesendet: Donnerstag, 30. Mai 2024 03:43
An: mxtommy/Kip
Cc: Joerg R. Plaschka; Author
Betreff: Re: [mxtommy/Kip] Update 2.10.0: values jumping between sources (Issue #420)
I see 8 different sources for path electrical.batteries.0.voltage
They appear to be for different batteries. If it's the case, you should configure one path for each battery instead of multiple sources for the same device (path).
* electrical.batteries.0.voltage
* electrical.batteries.1.voltage
* electrical.batteries.2.voltage
Etc.
I'm not saying there is no bug yet, but it's not good practice. Multiple Sources are meant to be used as backup providers for the same path. Line if you have 2 gps. Use gps-1 and if it's stops sending data or breaks down, use gps-2 so the path still gets the info.
Can you share a screenshot of the volt gauge configuration please.
—
Reply to this email directly, view it on GitHub<#420 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCGJ4N2355YV32N73FHDR63ZE2G5DAVCNFSM6AAAAABIOVIDIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYGU3TAOBYG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I'll run checks on multiple sources. Until I find the problem, please ask in the Server and Victron Discord channel how to change the setup. It's not how sources are intended to be used. Even if it worked before. You are at risk of having other problems down the road. It will probably be a much faster fix. I have 2 engines and 5 batteries myself and they all use single paths so it's something in the setup, or the plugins that needs a change. |
You can also down grade to the previous version until the fix. Uninstall KIP, restart the server and from the command line in the .signalk folder run: npm i @mxtommy/kip@2.9.3 |
Here is what I got from Discord:
See: |
I'm testing and I don't see source value jumps on my end. I've asked other user to check with their setup. Let's see if they report issues. That said, I strongly recommend you use the instructions above to clean up your setup and use individual paths. Go on Discord in the server channel to get support from the community. |
I understand David's annoyance, and I really appreciate everything he does to develop an amazing tool and share it with us. Having said that, I'm also seeing the same issue with the latest release. I have multiple sources for the same data, and I've configured KIP to display the data from a particular source. It has worked perfectly for a long time, but the latest KIP release normally shows the wrong source, and sometimes jumps rapidly between the two sources: @godind , is there anything I can do to help debug? |
Dear fellow fighters for good software,
I would like to make it clear that I do not know David as a person. As a result, I cannot and do not wish to criticise him personally.
My comments related to a piece of software for which I was and am prepared to invest my time. Deriving, recreating and documenting malfunctions or missing functions is not intended to criticise the developer, but to improve the software - for my benefit, of course, but also for the benefit of all users.
I would like to apologise if my previous comments were misleading or could even be taken as a personal attack! This was never my intention.
At the same time, however, I would like to call on you to work together on optimising the software in an objective manner and with a forward-looking approach. Emotions are never helpful in this process.
(Including on my part, even if none of my instruments work a second time after an update).
Cheers Joerg
Side note: English is not my native language and I am located in Europe. And yes, I partly use translation software.
…________________________________
Von: tvr256 ***@***.***>
Gesendet: Freitag, 31. Mai 2024 09:15
An: mxtommy/Kip
Cc: Joerg R. Plaschka; Author
Betreff: Re: [mxtommy/Kip] Update 2.10.0: values jumping between sources (Issue #420)
I understand David's annoyance, and I really appreciate everything he does to develop an amazing tool and share it with us.
Having said that, I'm also seeing the same issue with the latest release.
I have multiple sources for the same data, and I've configured KIP to display the data from a particular source. It has worked perfectly for a long time, but the latest KIP release normally shows the wrong source, and sometimes jumps rapidly between the two sources:
image.png (view on web)<https://github.com/mxtommy/Kip/assets/117984987/38b4cd98-434a-426e-9ff2-96b7a7f1af4c>
image.png (view on web)<https://github.com/mxtommy/Kip/assets/117984987/c908d8c2-f2f5-40f3-bdaf-c0e744e9c521>
image.png (view on web)<https://github.com/mxtommy/Kip/assets/117984987/f86ef9a0-9b1b-4c99-9d85-b133bb16b09b>
@godind<https://github.com/godind> , is there anything I can do to help debug?
—
Reply to this email directly, view it on GitHub<#420 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCGJ4N5YBMZLW4ZS3WOSE7TZFAWRRAVCNFSM6AAAAABIOVIDIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGQ2TGMRXG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
User Mat has found that using source Default or the first available source in the list is fine. The problem is only visible on sources past the first source. Possible workarounds until the fix is released are:
The last two workarounds are not bug fixes, but they are configuration corrections that will prevent hitting this bug and protect from possible issues in other circumstances. |
I confirm: with V2.10.01 multiple sources of one path are working again. |
When there are different sources for the identical path the values within the instrument panel are jumping to another source.
The values are not jumping within SK or KIP data browser.
SK data
https://github.com/mxtommy/Kip/assets/143433271/c08d1a0e-2e79-4ada-93de-83dfea9f13af
KIP data
https://github.com/mxtommy/Kip/assets/143433271/e11e3583-5c4a-4816-8f76-fcd7ace9be2c
KIP instrument
https://github.com/mxtommy/Kip/assets/143433271/d6e4f801-3400-4ac2-b952-7fb9911b90ce
The text was updated successfully, but these errors were encountered: