-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
what about migrate to yt-dlp? #237
Comments
Does that new binary just drop in to a new container, or does the code need to change as well? (of which when I tried playing with the code got a bit stuck not knowing golang #238 ) I've noticed really slow downloads as well. |
So I've worked out a new dockerfile that preforms a build of go first (I don't have the language). And have successfully built with your referred to yt-dlp. - holy hell it's so much faster. I'd also started adding for my own interest telling Plex to update but that code failed. But I backed that out and just left the changes to the downloaded. |
Hi, for an existing podsync instance that stopped working, do I understand properly from OP that you just install yt-dlp into the existing youtube-dl directory (the wget -O /usr/bin/youtube-dl https://github.com/yt-dlp/yt-dlp/releases/latest/download/yt-dlp command) and... that's basically it? (I'm running podsync through CLI on Raspbian) |
@derdide On standalone installation I have successfully tested creating softlink called youtube-dl aimed at yt-dlp. Podsync does not care and the download went through without a problem. |
@sutr90 sorry for the late reply, it took me a while to figure out what I was doing wrong - on Raspbian, youtube-dl is located in /usr/local/bin/ - so your wget above was working but was useless... I got it right now and yes, the DL speed is far better. |
Can you give me a hint to make this work on the docker container? |
@murmelbahn just replace Dockerfile and build image. |
Sorry for the maybe dump question but how do I do this? I cloned the repo and replacec the content of the Dockerfile with your Dockerfile. When I run docker build . I get the following error message: Step 4/6 : COPY podsync /app/podsync I dont know how to pass this error:( |
You need the binary for podsync. Go compiles it. The dockerfile as written needs a compiled binary to make the container. |
Aaah, thank you. That was the missing piece;) Now its working. |
Hi @mxpv , is this still planned? Cheers |
Yeah having this supported by default would be excellent! Also being able to configure the default timeout value of yt-dlp to something other than 10 mins would be excellent 👍 Thanks :) |
Yes, will I'll take a look, but PRs are welcome :) |
I'm not too experienced with the code here, but isn't the only thing that needs changing the Dockerfile? Does the rest of the code depend on YT-DL specifically? YT-DLP should be fully pin-compatible otherwise. |
Yeah tbh after doing some experimentation, I realised it is very easy to fix this problem on my end. I simply installed yt dlp to the same location as I would usually install the YouTube-dl binary, so it is activated by calls to YouTube-dl. I also figured out that compiling podsync code is as simple as typing "make" into the terminal of the project folder (this should probs be stated in the readme.md file :), so I was able to adjust the time out value from 10 mins to 35 mins which has significantly improved my download success rate. |
Can do a PR. Easiest would be to just update the Dockerfile to download the yt-dlp binary, but name it youtube-dl to prevent regressions. This could also be done with a different docker image tag. e.g. Else podsync could embrace yt-dlp and recommend it over youtube-dl with probably a new major version number because it would be a breaking change. This would involve a bigger refactor to yt-dlp. |
FYI, the PR to start using |
hey! I'm also having trouble with youtube-dl and I would like to try yt-dlp but I barely know what I'm doing here. Could you provide me with more details on how to do what you did? would be great. thanks |
@skofieldO5 I’m not sure on the ETA of the next release, but if you wait until then YT-DLP will be built in. |
@LewisSpring oh cool! Well I really don't care if it is youtube-dl or yt-dlp.
Any help with that would be great. I would like to surprise them that I turned their channel into a podcast ;) |
@skofieldO5 Do you run it in docker or another way? If in docker, you need an image with yt-dlp included (e.g. the one from Th0masL (th0masl/podsync:ytdlp) or hack it into the image (I use a custom entrypoint script to handle the modification) Either way, podsync does only supports binaries called |
@pagdot thanks! I made it work with a symlink. |
I see this issue hasn't had any activity for over a year, does the current release use yt-dlp? The documentation still says youtube-dl. I see there is a fork of it by another developer which does use yt-dlp, but it hasn't been updated since December and I would rather stick to the official repo. I can just run without Docker but I'd prefer not to. |
Current version uses Line 13 in 5c57096
|
Several weeks ago i stoped to get updates from podsync because youtube-dl (2021.06.06) can download video only on very slow speed (about 50kb/s). It was repeateble on several pc's in another locations.
While i do little research i try migrate my instance to https://github.com/yt-dlp/yt-dlp and it was work perfect. Also that have many additional features.
@mxpv what do you think about migrate from youtube-dl to yt-dlp?
The text was updated successfully, but these errors were encountered: