Skip to content

Commit

Permalink
ping/rust: Don't set PR ref for master build
Browse files Browse the repository at this point in the history
When building the `master` image we would previously mistakingly set the
ref to the PR commit hash.

This surfaced when testing a pull request from a fork. `master` would be
pointed at the forks HEAD commit hash, but not the fork URL. Thus the
build could not find the commit and would fail. See
libp2p/rust-libp2p#3154
  • Loading branch information
mxinden committed Nov 23, 2022
1 parent 17dcc6c commit e7934db
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ping/_compositions/rust-cross-versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

[groups.build_config.build_args]
BINARY_NAME = '{{ .BinaryName }}'
GIT_REF = '{{ $.Env.GitReference }}'
GIT_REF = "master"
{{ end }}

{{ if $.Env.GitReference }}
Expand Down

0 comments on commit e7934db

Please sign in to comment.