Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

framed/: Add send_high_water_mark and set_send_high_water_mark #3

Merged
merged 4 commits into from
Nov 8, 2022

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Nov 4, 2022

Otherwise, it's not possible to change default send_high_water_mark.

Copy link
Owner

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though needs version bump and changelog entry. I can cut a release right after.

Copy link
Owner

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @melekes!

CHANGELOG.md Outdated Show resolved Hide resolved
@mxinden mxinden changed the title add send_high_water_mark and set_send_high_water_mark to Framed framed/: Add send_high_water_mark and set_send_high_water_mark Nov 8, 2022
@mxinden mxinden merged commit 43338f6 into mxinden:master Nov 8, 2022
@melekes melekes deleted the anton/set-watermark branch November 8, 2022 10:13
@mxinden
Copy link
Owner

mxinden commented Nov 8, 2022

Tagged and published.

//CC @melekes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants