Fix YAML loading #61
Merged
Fix YAML loading #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liveh2o
force-pushed
the
ah/fix_yaml_loading
branch
from
4a87c36
to
70ee133
Compare
Psych (aka YAML) 4.x included a breaking change to how `YAML.load` works In Psych 4.0, `load` calls `safe_load` under the hood, and is therefore "safe" by default, but that breaks configurations that support (among other things) aliases, which are disabled when using "safe" loading. `unsafe_load` is now the canonical way to load trusted documents (i.e., config files): ruby/psych#533 (comment) To ensure maximum compatibility with old versions of Psych, we also need to set a minimum version of Psych to ensure `unsafe_load` is defined. The methods were introduced in v3.3.2: ruby/psych@cb50aa8 Resolves #60
liveh2o
force-pushed
the
ah/fix_yaml_loading
branch
from
70ee133
to
d518b4e
Compare
minond
approved these changes
Apr 27, 2022
|
Going to cut a prerelease of this to verify there aren't any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Psych (aka YAML) 4.x included a breaking change to how
YAML.loadworks In Psych 4.0,loadcallssafe_loadunder the hood, and is therefore "safe" by default, but that breaks configurations that support (among other things) aliases, which are disabled when using "safe" loading.unsafe_loadis now the canonical way to load trusted documents (i.e., config files): ruby/psych#533 (comment)To ensure maximum compatibility with old versions of Psych, we also need to set a minimum version of Psych to ensure
unsafe_loadis defined. The methods were introduced in v3.3.2: ruby/psych@cb50aa8Resolves #60