Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment variables created from magic commands #794

Merged
merged 3 commits into from
May 30, 2021

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented May 29, 2021

Variables created with magic commands like e.g.

result = %sql SELECT * FROM quickdemo WHERE value > 25

should be commented out in the .py representation.

Cf. #781

@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #794 (eda17a0) into master (1d63611) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
+ Coverage   99.11%   99.13%   +0.01%     
==========================================
  Files         106      106              
  Lines       10100    10147      +47     
==========================================
+ Hits        10011    10059      +48     
+ Misses         89       88       -1     
Impacted Files Coverage Δ
jupytext/cli.py 96.17% <100.00%> (+0.08%) ⬆️
jupytext/magics.py 100.00% <100.00%> (ø)
tests/test_cli.py 100.00% <100.00%> (ø)
tests/test_escape_magics.py 100.00% <100.00%> (ø)
jupytext/paired_paths.py 98.49% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112ed80...eda17a0. Read the comment docs.

@mwouts mwouts merged commit ba932cd into master May 30, 2021
@mwouts mwouts deleted the comment_magic_assignments branch May 30, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant