Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode characters in README cause issues on Pypi (display) and occasionally in pip install #71

Closed
DaisyLoveU opened this issue Sep 11, 2018 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@DaisyLoveU
Copy link

Please help~!
details:windows10 os,in cmd, pip3 install jupytext --upgrade (both have Python2 and Python3)

Looking in indexes: https://pypi.tuna.tsinghua.edu.cn/simple
Collecting jupytext
Using cached https://pypi.tuna.tsinghua.edu.cn/packages/1d/de/ae5c3a0b1a07a581db9cfe3ee74466f53cad19182a8d58b4e819de6dd783/jupytext-0.6.3.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\ZZCE57~1\AppData\Local\Temp\pip-install-2gipwivl\jupytext\setup.py", line 6, in
long_description = f.read()
UnicodeDecodeError: 'gbk' codec can't decode byte 0x94 in position 2178: illegal multibyte sequence

----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in C:\Users\ZZCE57~1\AppData\Local\Temp\pip-install-2gipwivl\jupytext\

And I can't find that File...

@mwouts
Copy link
Owner

mwouts commented Sep 11, 2018

Interesting! Thanks for reporting. I've seen indeed that some unicode characters in the README are not correctly displayed at pypi. We need to fix setup.py for that.

For now I recommend that

  • your clone the project from GitHub
  • you comment this line in setup.py : long_description = f.read()
  • change directory to the first jupytext folder (where setup.py is located), and run pip install -e . (don't forget the point)

@mwouts mwouts changed the title UnicodeError Unicode characters in README cause issues on Pypi (display) and occasionally in pip install Sep 11, 2018
@mwouts mwouts added the help wanted Extra attention is needed label Sep 11, 2018
@hktxt
Copy link

hktxt commented Sep 11, 2018

(Pytorch) C:\Users\Max>pip install jupytext --upgrade
Collecting jupytext
Downloading https://files.pythonhosted.org/packages/1d/de/ae5c3a0b1a07a581db9cfe3ee74466f53cad19182a8d58b4e819de6dd783/jupytext-0.6.3.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\Max\AppData\Local\Temp\pip-install-2qsrqm7d\jupytext\setup.py", line 6, in
long_description = f.read()
UnicodeDecodeError: 'gbk' codec can't decode byte 0x94 in position 2178: illegal multibyte sequence


same issue.

@DaisyLoveU
Copy link
Author

DaisyLoveU commented Sep 11, 2018

@mwouts hi,Marc. I've clone this project and add encoding='utf-8' in line 5 for open() function, then run python setup.py install, finally, it succeeded! Hope you can add this parameter, cause may lots of Chinese meet this issue. Thank you!

@mwouts
Copy link
Owner

mwouts commented Sep 11, 2018

Thanks @DaisyLoveU . Sure I will correct for this in v0.6.4. Thanks for the tip. By the way - I've found a similar issue and resolution at mozilla/unicode-slugify#16, so we must be on the right way with your change!

mwouts added a commit that referenced this issue Sep 11, 2018
@mwouts mwouts mentioned this issue Sep 11, 2018
@mwouts
Copy link
Owner

mwouts commented Sep 11, 2018

@DaisyLoveU , could you please upgrade to v0.6.4 (from pypi) and test? With

pip install jupytext==0.6.4

Thanks!

@DaisyLoveU
Copy link
Author

Thank you @mwouts for @ me! I am glad to do it! This time it goes well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants