expect no longer tries to equal non-enumerable symbolic properties. F…

…ixes jestjs#6392
mweststrate · Jun 5, 2018 · a34fcb8 · a34fcb8
1 parent 241588a
commit a34fcb8
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 ## master
 
+### Fixes
+
+- `[expect]` `toEqual` no longer tries to compare non-enumerable symbolic properties, to be consistent with non-symbolic properties. ([]())
+
 ## 23.1.0
 
 ### Features

diff --git a/packages/expect/src/__tests__/matchers.test.js b/packages/expect/src/__tests__/matchers.test.js
@@ -442,6 +442,29 @@ describe('.toEqual()', () => {
       );
     }
   });
+
+  test('non-enumerable members should be skipped during equal', () => {
+    const actual = {
+      x: 3
+    };
+    Object.defineProperty(actual, "test", {
+          enumerable: false,
+          value: 5
+    });
+    expect(actual).toEqual({ x: 3 });
+  });
+
+  test('non-enumerable symbolic members should be skipped during equal', () => {
+    const actual = {
+      x: 3
+    };
+    const mySymbol = Symbol("test");
+    Object.defineProperty(actual, mySymbol, {
+          enumerable: false,
+          value: 5
+    });
+    expect(actual).toEqual({ x: 3 });
+  });
 });
 
 describe('.toBeInstanceOf()', () => {

diff --git a/packages/expect/src/jasmine_utils.js b/packages/expect/src/jasmine_utils.js
@@ -209,7 +209,11 @@ function keys(obj, isArray, hasKey) {
         keys.push(key);
       }
     }
-    return keys.concat((Object.getOwnPropertySymbols(o): Array<any>));
+    return keys.concat(
+      (Object.getOwnPropertySymbols(o): Array<any>).filter(
+        symbol => Object.getOwnPropertyDescriptor(o, symbol).enumerable,
+      ),
+    );
   })(obj);
 
   if (!isArray) {