Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with --password #535

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix issues with --password #535

wants to merge 4 commits into from

Conversation

echuber2
Copy link
Contributor

@echuber2 echuber2 commented Sep 18, 2024 •
edited
Loading

Fixes #537

There are problems with using --password because set_password is called before check_hostuser, but check_hostuser is where Unpriv gets set, which set_password relies on. This PR defers the set_password call until after check_hostuser, and it also adds some error checking (based on what I used to debug the issue).

@echuber2 echuber2 mentioned this pull request Sep 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using --password fails if ~/.config/x11docker doesn't exist
1 participant
@echuber2