Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TensorFlow Decoder, NodeContext, and additional API for integration with OVTF #37

Merged
merged 9 commits into from
Sep 27, 2021
Merged

Implement TensorFlow Decoder, NodeContext, and additional API for integration with OVTF #37

merged 9 commits into from
Sep 27, 2021

Conversation

rkazants
Copy link
Collaborator

@rkazants rkazants commented Sep 26, 2021 •
edited
Loading

Details:

  • Introduce new classes DecoderTFProto and NodeContext aligned with PDPD frontend
  • Removed all old Decoder and NodeContext and dependencies from them
  • Introduce DecoderBase and GraphIterator classes for integration with OVTF pipeline
  • Implementation gets clean and organizes with frontend exceptions
  • Remove redundant header inclusions in sources

Tickets: 62406, 62689

@rkazants
Implement TensorFlow NodeContext and DecoderTFProto classes
3cd6e62 
Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
@rkazants
Switch to new NodeContext
f29cec3 
Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
@rkazants
Merge remote-tracking branch 'mvafin/tf_frontend' into tf_frontend/tf…
c865020 
…_node_context

Resolve conflicts in the following files:
#	ngraph/frontend/tensorflow/include/tensorflow_frontend/node_context.hpp
#	ngraph/frontend/tensorflow/src/ngraph_builder.cpp
#	ngraph/frontend/tensorflow/src/node_context_impl.hpp
#	ngraph/frontend/tensorflow/src/proto_context.cpp

Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
@rkazants
Remove ngraph_builder class and node_context_impl class
bbdcbbf 
Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
@rkazants
Move decoder/graph_iterator to separate files and remove old files
64bd6d4 
Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
@rkazants
Document Decoder, GraphIterator, and NodeContext classes
a442040 
Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
@rkazants rkazants changed the title Tf frontend/tf node context Implement TensorFlow Decoder and NodeContext, and implement API for integration with OVTF Sep 26, 2021
@rkazants rkazants changed the title Implement TensorFlow Decoder and NodeContext, and implement API for integration with OVTF Implement TensorFlow Decoder, NodeContext, and additional API for integration with OVTF Sep 26, 2021
@rkazants
Apply code style
a912e73 
Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
mvafin
mvafin requested changes Sep 27, 2021
View reviewed changes
Copy link
Owner

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an empty file: ngraph/frontend/tensorflow/src/graph_iterator_proto.cpp
I think better to remove it if not needed

ngraph/frontend/tensorflow/include/tensorflow_frontend/exceptions.hpp Outdated Show resolved Hide resolved
ngraph/frontend/tensorflow/include/tensorflow_frontend/model.hpp Outdated Show resolved Hide resolved
ngraph/frontend/tensorflow/include/tensorflow_frontend/place.hpp Show resolved Hide resolved
ngraph/frontend/tensorflow/src/frontend.cpp Outdated Show resolved Hide resolved
ngraph/frontend/tensorflow/src/frontend.cpp Outdated Show resolved Hide resolved
ngraph/frontend/tensorflow/src/graph_iterator_proto.hpp Outdated Show resolved Hide resolved
ngraph/frontend/tensorflow/src/model.cpp Outdated Show resolved Hide resolved
@rkazants
Remove empty file graph_iterator_proto.cpp and redundant comments
ff4f7ec 
Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
@rkazants
Use base class for GraphIterator in model class and correct exception…
3c2608f 
… class

Signed-off-by: Roman Kazantsev <roman.kazantsev@intel.com>
@rkazants rkazants merged commit 9bfa16b into mvafin:tf_frontend Sep 27, 2021
mvafin added a commit that referenced this pull request Nov 21, 2022
@mvafin
Merge pull request #37 from mvafin/mvafin/pt_fe/extra_outs_fix
3ecb6b2 
Do not create extra outputs in main body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvafin mvafin mvafin approved these changes

@itikhono itikhono itikhono approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkazants @mvafin @itikhono