fix: add media metadata via ffprobe-static #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which includes binaries
luwes
force-pushed
the
media-metadata
branch
from
cc731ae to
809b21f
Compare
mmcc
reviewed
Sep 14, 2023
| @@ -111,6 +114,7 @@ export default function NextVideo(props: NextVideoProps) { | |||
| poster="" | |||
| style={{ | |||
| '--controls': controls === false ? 'none' : undefined, | |||
| aspectRatio: aspectRatio !== '16/9' ? aspectRatio : undefined, | |||
There was a problem hiding this comment.
What's the reasoning behind this check? We don't want to use the aspect ratio if it's 4:3 or otherwise?
There was a problem hiding this comment.
the default is 16 / 9 defined in the inline <style> tag. if it's the same than 16/9 we skip setting it as an inline style attribute
|
Anything left to do on this one? |
|
I think we decided not to pursue this for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #22
ffprobe-static includes binaries for each platform
https://github.com/eugeneware/ffmpeg-static/tree/master/packages/ffprobe-static