Skip to content

Commit

Permalink
chore(mux-player, mux-player-react)!: breaking change take 2 (#994)
Browse files Browse the repository at this point in the history
Fool me once...

BREAKING CHANGE: Retrospective breaking change for tooltips pr
  • Loading branch information
AdamJaggard committed Sep 20, 2024
1 parent 370c5dc commit 668403a
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
9 changes: 9 additions & 0 deletions README_INTERNAL.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@ Examples:
- include `--scope '*-esm'` in the dev script
- Run `npx lerna run dev --scope '*-esm'` locally after running `yarn dev`

## Testing your changes to see what affect they have on version updates

You can do a dry-run locally of the `version:update` script by doing the following:

1. Create a new branch from `main`
2. Cherry pick commits from your working branch to it, including any needed footer e.g. "BREAKING CHANGE: ..."
3. Push new branch to remote
4. Run the script `yarn version:update` and select 'n' (no) for committing to the changes

# Media Chrome Canaries

It's helpful to point at Media Chrome canaries for developing PRs and having all the live examples work; however, we should not merge any PRs that point at a Media Chrome Canary release.
Expand Down
1 change: 0 additions & 1 deletion packages/mux-player-react/src/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
'use client';

import React, { useEffect } from 'react';
import type { CSSProperties } from 'react';
import type {
Expand Down
1 change: 0 additions & 1 deletion packages/mux-player/src/html.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { document } from './polyfills';
// @ts-ignore
import { TemplateInstance, ChildNodePart, AttrPart, Part } from 'media-chrome/dist/media-theme-element.js';

// NOTE: These are either direct ports or significantly based off of github's jtml template part processing logic. For more, see: https://github.com/github/jtml
Expand Down

0 comments on commit 668403a

Please sign in to comment.