Add custom umbrella header for Carthage framework #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Hugely sorry for the delay here. I've added this in as part of the watchOS branch system. You can check it out at the link below. It should be merged in as 1.3.0 in the next day or two. Thanks @tomguthrie @carlossless https://github.com/mutualmobile/MMWormhole/tree/watchOS_example_carthage |
|
Closing PR as I pulled @tomguthrie's branch directly into mine. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #56 by adding the missing headers to a custom umbrella header defined in a module.modulemap file. This means the CocoaPods side doesn't have to change, and I believe this is similar to what they do anyways.
I also moved
MMWormholeVersionNumberandMMWormholeVersionStringto the new umbrella header because I don't think they're needed for the CocoaPods version?(It also ticks "Allow app extension API only" but I can remove that if needed.)