Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when updating to 0.13.2 #199

Closed
bdashore3 opened this issue Sep 22, 2020 · 7 comments
Closed

Error when updating to 0.13.2 #199

bdashore3 opened this issue Sep 22, 2020 · 7 comments

Comments

@bdashore3
Copy link

Hi, I'm getting this error and just recently updated the lib to 0.13.2 in my cargo.toml

https://del.dog/bestotocke.txt

@bdashore3
Copy link
Author

Ok, so I figured out the reason, I have to include futures-lite in my cargo.toml and cargo check works. Can you include this within dependencies?

museun added a commit that referenced this issue Sep 23, 2020
@museun
Copy link
Owner

museun commented Sep 23, 2020

It seems futures-lite feature gated those traits in a recent update.

I don't know why the tests didn't catch it. I've fixed it in 36ccccc

@museun museun closed this as completed Sep 23, 2020
@tAq5Z6eE
Copy link
Contributor

It looks like the same error has been re-introduced by 9f33ac4.

@museun
Copy link
Owner

museun commented Sep 29, 2020

Are you using (atleast) features = [ "async" ]?

@tAq5Z6eE
Copy link
Contributor

Yes, I’m using

[dependencies]
twitchchat = { version = "0.14.3", features = ["async", "tokio", "tokio-util"] }

in my Cargo.toml.

@museun
Copy link
Owner

museun commented Sep 29, 2020

So, this is actually a bug in cargo. If I were to build the crate with this features it works.

This happened a while with #84

I guess I should have an external crate that uses this one in the various features configurations to ensure the breakages are caught before publication.

And its technically fixed on nightly: rust-lang/cargo#1796 (comment)

(The problem is that features from dev-dependencies will 'leak' out and cargo will unify both dev and normal deps when its expanding to find the 'widest' feature set among all related crates)

But until then I'll be a bit more diligent about it.

@museun museun reopened this Sep 29, 2020
@museun museun closed this as completed in a61c513 Sep 29, 2020
@museun
Copy link
Owner

museun commented Sep 29, 2020

and I just published a new release that fixes this. I'll make a mental note to do the external feature testing before publishing next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants