[MU3] Allow the user to customize background when exporting as PDF/PNG/SVG #7500

sidharth-anand · 2021-02-12T13:24:00Z

Resolves: https://musescore.org/en/node/293370

This patch provides the user complete control over the background when exporting the score to a PDF/PNG/SVG file, allowing the user to choose between a transparent background, the background currently used in the score (both solid colors and images) or a custom color.

Note: To be able to see the transparent background when exporting as a pdf, you will have to turn on the "Show Transparency Grid" or equivalent option in your pdf viewer or the transparent area gets filled with white by default.

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

Jojo-Schmitz · 2021-02-12T13:33:43Z

global/settings/types/preferencekeys.h

@@ -66,6 +66,8 @@
 #define PREF_EXPORT_PDF_DPI                                 "export/pdf/dpi"
 #define PREF_EXPORT_PNG_RESOLUTION                          "export/png/resolution"
 #define PREF_EXPORT_PNG_USETRANSPARENCY                     "export/png/useTransparency"
+#define PREF_EXPORT_BG_STYLE								"export/bg/style"
+#define PREF_EXPORT_BG_CUSTOM_COLOR							"export/bg/customcolor"


Use spaces here, not tabs

Jojo-Schmitz · 2021-02-12T13:35:08Z

mscore/file.cpp

@@ -2187,6 +2216,21 @@ bool MuseScore::savePdf(QList<Score*> cs_, const QString& saveName)
                  if (!firstPage)
                        printer.newPage();
                  firstPage = false;
+
+                  switch (exportBgStyle) {
+                  case 1:


indent one level more starting here

cbjeukendrup · 2021-03-01T15:43:59Z

mscore/exportdialog.ui

+   <property name="leftMargin">
+    <number>0</number>
+   </property>
+   <property name="topMargin">
+    <number>0</number>
+   </property>
+   <property name="rightMargin">
+    <number>0</number>
+   </property>
+   <property name="bottomMargin">
+    <number>0</number>
+   </property>


Why are the margins changed? I don't think this is intended... please undo this (remove these 12 lines).

cbjeukendrup · 2021-03-01T18:43:14Z

I would like to suggest a quick design tweak: (see mock-up)

…/PNG/SVG

vpereverzev · 2021-03-10T17:57:16Z

Hi @sidharth-anand, we're not planning to release 3.x anymore, but I guess it might be useful for 4.0
Is it already included in your counter-part for master? If so, I'd close this one

Jojo-Schmitz · 2021-03-10T17:58:48Z

Even if it is, please merge to 3,x too, it is easier to test it with a 3.x development build

Also plans can change...

And that preferences stuff is not yet in master anyhow as far as I can tell
Anyway: as far as I can see this PR here is not included in the other one

sidharth-anand · 2021-03-11T05:33:45Z

@vpereverzev it's not included in my PR for the export dialog currently. I was thinking of making a separate PR porting this to master once the export dialog and the preferences and somewhat stable in master

Jojo-Schmitz · 2021-03-17T08:02:34Z

Needs #7704 too

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 compiler warnings it introduced

Jojo-Schmitz · 2021-09-04T10:26:34Z

Wouldn't that new preference also need to get added to the dialog in Edit > Preferences > Export > PNG and ...PDF (there is none for ...SVG)?

Have you done a port of this to master meanwhile? (Edit: apparently not, but probably should)
(I've added this one here to #9000 meanwhile, so I guess it can get closed?)

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 MinGW compiler warnings it introduced.

RomanPudashkin · 2022-12-20T08:55:30Z

3.x is closed for any changes

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 MinGW compiler warnings it introduced.

Jojo-Schmitz mentioned this pull request Feb 12, 2021

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

igorkorsukov changed the title ~~Allow the user to customize background when exporting as PDF/PNG/SVG~~ [MU3] Allow the user to customize background when exporting as PDF/PNG/SVG Feb 12, 2021

Jojo-Schmitz suggested changes Feb 12, 2021

View reviewed changes

sidharth-anand force-pushed the 293370-export-background branch 2 times, most recently from 6a5d5ba to 5e968d8 Compare February 12, 2021 19:06

cbjeukendrup reviewed Mar 1, 2021

View reviewed changes

Fix #293370: Allow user to customize background when exporting as PDF…

5e61766

…/PNG/SVG

sidharth-anand force-pushed the 293370-export-background branch from 5e968d8 to 5e61766 Compare March 2, 2021 10:24

Jojo-Schmitz mentioned this pull request Sep 1, 2021

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 4, 2021

Fix #293370: Allow user to customize background when exporting as PDF…

fba3939

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 compiler warnings it introduced

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 4, 2021

Fix #293370: Allow user to customize background when exporting as PDF…

5009ce1

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 MinGW compiler warnings it introduced.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 4, 2021

Fix #293370: Allow user to customize background when exporting as PDF…

4e210c7

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 MinGW compiler warnings it introduced.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 9, 2021

Fix #293370: Allow user to customize background when exporting as PDF…

7b6f5f0

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 MinGW compiler warnings it introduced.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021

Fix #293370: Allow user to customize background when exporting as PDF…

16f7f59

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 MinGW compiler warnings it introduced.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021

Fix #293370: Allow user to customize background when exporting as PDF…

d73d934

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 MinGW compiler warnings it introduced.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 24, 2021

Fix #293370: Allow user to customize background when exporting as PDF…

3b07ada

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 MinGW compiler warnings it introduced.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 26, 2021

Fix #293370: Allow user to customize background when exporting as PDF…

f7b4350

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 MinGW compiler warnings it introduced.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 29, 2021

Fix #293370: Allow user to customize background when exporting as PDF…

8ad8e3f

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 MinGW compiler warnings it introduced.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022

Fix #293370: Allow user to customize background when exporting as PDF…

f25779a

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 MinGW compiler warnings it introduced.

RomanPudashkin closed this Dec 20, 2022

Jojo-Schmitz mentioned this pull request Mar 1, 2023

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023

Fix #293370: Allow user to customize background when exporting as PDF…

492f790

…/PNG/SVG Duplicate of musescore#7500, plus fix 2 MinGW compiler warnings it introduced.

Jojo-Schmitz mentioned this pull request May 25, 2024

Combined PDF export is faulty Jojo-Schmitz/MuseScore#487

Closed

Jojo-Schmitz mentioned this pull request May 27, 2024

Export selected parts to a single file #22995

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MU3] Allow the user to customize background when exporting as PDF/PNG/SVG #7500

[MU3] Allow the user to customize background when exporting as PDF/PNG/SVG #7500

sidharth-anand commented Feb 12, 2021

Jojo-Schmitz Feb 12, 2021

Jojo-Schmitz Feb 12, 2021 •

edited

Loading

cbjeukendrup Mar 1, 2021

cbjeukendrup commented Mar 1, 2021

vpereverzev commented Mar 10, 2021

Jojo-Schmitz commented Mar 10, 2021 •

edited

Loading

sidharth-anand commented Mar 11, 2021

Jojo-Schmitz commented Mar 17, 2021

Jojo-Schmitz commented Sep 4, 2021 •

edited

Loading

RomanPudashkin commented Dec 20, 2022

[MU3] Allow the user to customize background when exporting as PDF/PNG/SVG #7500

[MU3] Allow the user to customize background when exporting as PDF/PNG/SVG #7500

Conversation

sidharth-anand commented Feb 12, 2021

Jojo-Schmitz Feb 12, 2021

Choose a reason for hiding this comment

Jojo-Schmitz Feb 12, 2021 • edited Loading

Choose a reason for hiding this comment

cbjeukendrup Mar 1, 2021

Choose a reason for hiding this comment

cbjeukendrup commented Mar 1, 2021

vpereverzev commented Mar 10, 2021

Jojo-Schmitz commented Mar 10, 2021 • edited Loading

sidharth-anand commented Mar 11, 2021

Jojo-Schmitz commented Mar 17, 2021

Jojo-Schmitz commented Sep 4, 2021 • edited Loading

RomanPudashkin commented Dec 20, 2022

Jojo-Schmitz Feb 12, 2021 •

edited

Loading

Jojo-Schmitz commented Mar 10, 2021 •

edited

Loading

Jojo-Schmitz commented Sep 4, 2021 •

edited

Loading