[MU3] Don't save default settings to pre 3.6 score after 'reset to defaults' #7441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: Lengthy discussion in the Developers' chat on Telegram ;-)
Importing a pre-3.6 score into 3.6, and then using Format > Style.. > Reset All Styles to Default, then saving the score does result in all the default settings being written into the score, including the tag
<usePre_3_6_defaults>1</usePre_3_6_defaults>
.Closing, opening it again and saving it again (with or without any change results in the score to now (correctly!) not contain any of the default settings anymore, and that
<usePre_3_6_defaults>1</usePre_3_6_defaults>
is gone too.With the change from this PR that workaround of a 2nd save is no longer needed.
Helps a lot if you want to open that score in a pre-3.6 version, it then no longer errnously falls back from Leland to Bravura rather then Emmentaler as the Musical font, from Leland Text to nothing for the Musical Text font rather than Emmentaler Text and, worst, from Edwin to "MS Shell Dlg2" (on Windows, on Mac and Linux it'd be some other fallback font) rather than FreeSerif.
What I'm unsure about is the use, need and sense of
<metaTag name="mscVersion">3.02</metaTag>
, and whether we'd not better get rid of it altogether, or at least remove it again on score write, As we do have<museScore version="3.02">
this seems to be just (very) redundant. But this might be for a different PR...Counterpart for master is #7508 and got merged meanwhile too