Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #316896: Banjo fifth string fret numbers #7439

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

laturetab
Copy link
Contributor

The banjo 5th string starts at the 5th fret, so valid fret
numbers are 0,6,7,8... Musescore displays 0,1,2,3...

This fix requires no UI changes and no file format changes.

Resolves: 316896

  • [ x] I signed CLA
  • [ x] I made sure the code in the PR follows the coding rules
  • [x ] I made sure the code compiles on my machine
  • [x ] I made sure there are no unnecessary changes in the code
  • [x ] I made sure the title of the PR reflects the core meaning of the issue you are solving
  • [x ] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [x ] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

The banjo 5th string starts at the 5th fret, so valid fret
numbers are 0,6,7,8... Musescore displays 0,1,2,3...

This fix requires no UI changes and no file format changes.
@Jojo-Schmitz
Copy link
Contributor

Ah, this looks better

@vpereverzev vpereverzev merged commit 9caa773 into musescore:3.x Feb 8, 2021
@igorkorsukov
Copy link
Contributor

@laturetab Could you please port the changes to the master

@laturetab
Copy link
Contributor Author

laturetab commented Feb 15, 2021 via email

@Jojo-Schmitz
Copy link
Contributor

Just do the same code change to the master branch

@laturetab laturetab deleted the 316896-banjofifthstring branch February 16, 2021 15:02
@Jojo-Schmitz
Copy link
Contributor

#7542 is the counterpart for master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants