Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #287598: Do not remove spanners from the measures outside of the rewrite range. #7359

Conversation

WcRnm
Copy link
Contributor

@WcRnm WcRnm commented Jan 28, 2021

Resolves: https://musescore.org/en/node/287598

Spanners in the measure following a range of measures were deleted during a rewrite.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@vpereverzev vpereverzev merged commit b9956cb into musescore:3.x Feb 3, 2021
@igorkorsukov
Copy link
Contributor

@WcRnm Could you please port the changes to the master

@WcRnm
Copy link
Contributor Author

WcRnm commented Feb 15, 2021

@igorkorsukov Yes, I should be able to get to the port to master later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants