Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] fix #316536: Add missing baritone-horns and euphoniums to orders.xm… #7356

Merged
merged 1 commit into from
Mar 5, 2021
Merged

[MU3] fix #316536: Add missing baritone-horns and euphoniums to orders.xm… #7356

merged 1 commit into from
Mar 5, 2021

Conversation

bmarwell
Copy link

…l and templates

Resolves: https://musescore.org/en/node/316536

Adds euphoniums especially to Brass Ensembles and European Concert Bands.
Just for completeness, although not too common, also to orchestral.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

share/instruments/orders.xml Show resolved Hide resolved
share/instruments/orders.xml Show resolved Hide resolved
share/instruments/orders.xml Show resolved Hide resolved
@igorkorsukov igorkorsukov changed the title fix #315963: Add missing baritone-horns and euphoniums to orders.xm… [MU3] fix #315963: Add missing baritone-horns and euphoniums to orders.xm… Feb 5, 2021
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 8, 2021

Commit- and PR title is wrong, should be #316536
Also you have marked the conversations resolved but not submitted the requested changes

@bmarwell
Copy link
Author

bmarwell commented Feb 8, 2021

Commit- and PR title is wrong, should be #316536
Also you have marked the conversations resolved but not submitted the requested changes

Sorry, something went wrong when pushing the update (which I did not see). But as I had the commit ready (and thought I pushed it), I already resolved the conversations.

Anyway, PR is updated now.

@bmarwell bmarwell changed the title [MU3] fix #315963: Add missing baritone-horns and euphoniums to orders.xm… [MU3] fix #316536: Add missing baritone-horns and euphoniums to orders.xm… Feb 8, 2021
@vpereverzev vpereverzev merged commit c5037c7 into musescore:3.x Mar 5, 2021
@Jojo-Schmitz
Copy link
Contributor

I wonder whether this would need to get ported to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants