Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4] Enable Ctrl+Shift+# to add a sharp for some non-US keyboards, add Synalepha shortcut #7100

Merged
merged 2 commits into from
Feb 5, 2021

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Dec 16, 2020

  • Enable Ctrl+Shift+# to add a sharp for some non-US keyboards like German QWERTY, British and Spanish QWERTZ, Belgian and French AZERTY
  • Fix #313195: Add Synalepha shortcut (so far only in 'normal text edit mode, but not for Lyrics, watch this space...)

Resolves: https://musescore.org/en/node/314375 (forum topic) and https://musescore.org/en/node/313195

This is for master what #6928, #7093. #7099, #7105 are for 3.x

like German QWERTY, British and Spanish QWERTZ, Belgian and French AZERTY
@Jojo-Schmitz Jojo-Schmitz changed the title [MU4] Enable Ctrl+Shift+# to add a sharp for some non-US keyboards [MU4] Enable Ctrl+Shift+# to add a sharp for some non-US keyboards, add Synalepha shortcut Dec 16, 2020
@Asmatzaile
Copy link
Contributor

editlyrics.cpp could be updated with your fix :)

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 17, 2020

Hmm, I don't find the place to add this, there's no 'editlyrics.cpp' and no ScoreView::editKeyLyrics() anymore it seems?!?

@Asmatzaile
Copy link
Contributor

Asmatzaile commented Dec 17, 2020

I'm not sure but I think some relevant code could be at libmscore/lyrics.cpp, lines 454-461

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 17, 2020

Hmm, I don't think this:

QApplication::clipboard()->setText(txt, mode);
if (minus) {
scoreview->lyricsMinus();
} else if (underscore) {
scoreview->lyricsUnderscore();
} else {
scoreview->lyricsTab(false, false, true);
}
is the right place. Similar code is in 3.x (almost identical):
if (minus)
scoreview->lyricsMinus();
else if (underscore)
scoreview->lyricsUnderscore();
else
scoreview->lyricsTab(false, false, true);
and there it wasn't the right place

@Asmatzaile
Copy link
Contributor

Hm, maybe lyric editing hasn't been added to mu4 yet. I tried the ctrl+L shortcut in the latest nightly and it didn't work.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 17, 2020

Oops. You can edit lyrics though.

@Asmatzaile
Copy link
Contributor

Oh, that's true.
The functionality that makes a dash and goes to the next note when hitting the minus key doesn't work however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants