-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU3] Paren time sig #6917
[MU3] Paren time sig #6917
Conversation
4f39313
to
18f1700
Compare
3207e8e
to
ac39238
Compare
@elerouxx do you have any clue why these changes do not set the parser string? |
You mean timeSig.cpp @ 261? I don't think the (old) variable is getting set true for these types. This variable seems to be for a very old time signature implementation that had a sequence of nominators. (additive?). |
ac39238
to
068c09f
Compare
…em programmatically in older scores.
068c09f
to
ab1806d
Compare
okay, this is now ready. As soon as elerouxx's PR is merged this one can be too. (or both can be merged at the same time with this PR) So here's how it works: When older scores are loaded, if these scores are using MuseJazz, then the symbols are corrected. |
The vtest fails are actually fixes (esp. for Emmentaler), before: Similar in #6550 (comment) Note that the MuseJazz text reads Emmentaler... |
3.x merges are closed |
Resolves: https://musescore.org/en/node/313219#comment-1042033
NOTE: This PR needs elerouxx's PR to be merged first (#6550 )
MuseJazz includes parentheses by default in its time signatures. With elerouxx's PR #6550 it is now possible to append them manually. As such, new scores created with 3.6 will not have this trailing parenthesis by default.
The change to MuseJazz hasn't been done yet, but because I have no development machine right now, I am testing with the build here and the artifacts generated while I remove the MuseJazz Parentheses.