InstrumentOrdering updates #6880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e trackName can be translated end therefor not be found. If the score file doesn't contain a instrumentId for an instrument, use the MusicXML to find the instrumentId for that If no instrumentId is found and fall back on famly <unsorted>.
74 tasks
vpereverzev
approved these changes
Nov 17, 2020
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 3, 2021
vpereverzev
pushed a commit
that referenced
this pull request
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves a few issues found in the score ordering:
In the
InstrumentsWidget, the fieldOrderingwas initial empty. This causes a crash later on. Now the field will show the first score order, which isOrchestraIn the original PR,
trackNamewas used for score ordering. However, this can be translated so no instrument could be found for ordering. The result was a crash. Now theinstrumentIdfrominstruments.xmlis used, and now also stored in the score file. This makes score ordering independent from any translation or rename of instrument used. As a consequence several reference file are updated to include thisinstrumentId.For backwards compatibility, during the load of a score file, every instrument is checked for
instrumentId. If thisinstrumentIdis not found,MusicXMLIdis used to find theinstrumentId.I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made