Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #307271 : [Musicxml Export] - Wrong tuplet calculation in two-note tremolo #6837

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

AntonioBL
Copy link
Contributor

Resolves: https://musescore.org/en/node/307271

This fixes a bug in tuplet import (tick was not set, so when deleting a tuplet in a file imported from xml there was corruption) and in xml import of a two-note tremolo at the beginning of a tuplet. It adds the optional tuplet-actual and tuples-normal fields in MusicXML export for compatibility with some Braille exporting softwares.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@AntonioBL
Copy link
Contributor Author

The case of nested tuplet import is not dealt with, since import of MusicXML nested tuplets is not implemented yet. (But export works ok)

@vpereverzev vpereverzev merged commit 5c7c49e into musescore:master Nov 16, 2020
@AntonioBL AntonioBL deleted the xmltremolotuplet branch November 18, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants