fix #308469: changing portaudio preferences does not work (3.x) #6523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2020
|
rebase needed |
Jojo-Schmitz
reviewed
Oct 5, 2020
| PreferenceItem::apply(newValue); | ||
| _initialEditorIndex = _editorComboBox->currentIndex(); |
There was a problem hiding this comment.
this here is where the merge conflict happens and only due to an excess 'space' character
There was a problem hiding this comment.
I'll take care of it when I am back at my computer.
|
As #6621 has been merged, this here can get closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/308469
3.x version of: #6423
PortAudio does not work perfectly on my machine (options are missing), but I don't think that has to do with the preferences. The problem was that the preferences related to it were not added to the new system. I added them and fixed some bugs with combo boxes.