Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #294384: Curly braces do not scale with staff when Bravura or Mus… #6496

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

elerouxx
Copy link
Contributor

@elerouxx elerouxx commented Aug 26, 2020

…eJazz font is used

Resolves: https://musescore.org/en/node/294384

Fixed Bravura and MuseJazz BRACE bracket (curly brace) scaling properly to staff magnitude.
(Removed an unnecessary calculation that was actually making the bracket bigger as the staff was scaled down).

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [n/A] I created the test (mtest, vtest, script test) to verify the changes I made

@anatoly-os anatoly-os merged commit 89923e6 into musescore:3.x Sep 1, 2020
anatoly-os added a commit that referenced this pull request Sep 2, 2020
njvdberg added a commit to njvdberg/MuseScore that referenced this pull request Sep 29, 2020
Restore scaling caused by the parameters "Staff space". This was inadvertently removed by solving scaling due to  scaled staves (PR musescore#6496).
njvdberg added a commit to njvdberg/MuseScore that referenced this pull request Oct 3, 2020
Restore scaling caused by the parameters "Staff space". This was inadvertently removed by solving scaling due to  scaled staves (PR musescore#6496).
vpereverzev pushed a commit that referenced this pull request Oct 5, 2020
Restore scaling caused by the parameters "Staff space". This was inadvertently removed by solving scaling due to  scaled staves (PR #6496).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants