Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized chord symbol/fretboard alignment algorithm #6321

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Optimized chord symbol/fretboard alignment algorithm #6321

merged 1 commit into from
Jul 14, 2020

Conversation

njvdberg
Copy link
Contributor

Optimized chord symbol/fretboard alignment algorithm:

  1. Supports multiple elements at same segment.
  2. Works on autoplaced elements only.
  3. Invisible elements will be aligned but are not used as a reference.
  4. Manual placed elements will be ignored for reference but will be moved and will remain its relative position with respect to the aligned element.
  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@MarcSabatella MarcSabatella mentioned this pull request Jul 10, 2020
Closed
1 task
@njvdberg
Optimized chord symbol/fretboard alignment algorithm:
9fadd1f 
1) Supports multiple elements at same segment.
2) Works on autoplaced elements only.
3) Invisible elements will be aligned but are not used as a reference.
4) Manual placed elements will be ignored for reference but will be moved
   and will remain its relative position with respect to the aligned element.
@njvdberg njvdberg force-pushed the manual-placed-chord-alignment branch from 55d4a5a to 9fadd1f Compare July 11, 2020 08:27
@njvdberg njvdberg mentioned this pull request Jul 13, 2020
Closed
29 tasks
@vpereverzev vpereverzev merged commit 0c5221d into musescore:3.x Jul 14, 2020
anatoly-os added a commit that referenced this pull request Aug 11, 2020
@anatoly-os
Manually merged #6321 to master
3cc24c3
@njvdberg njvdberg deleted the manual-placed-chord-alignment branch August 15, 2020 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njvdberg @vpereverzev