fix #307428: don't disable "remove selected range" #6280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://musescore.org/en/node/307428 A recent change simplified the handling of the remove selected range command in the right-click menu, but also disabled it for elements other than rests. Unfortunately, it was never re-enabled, leaving you unable to delete measures after right-clicking something other than a rest. There is no good place to re-enable it as far as I know, so I have changed this to simply not disable it. Instead, I don't display it at all except for rests or notes. This doesn't change the *measure* popup, only the *object* popup.
1 task
anatoly-os
added a commit
that referenced
this pull request
Jul 7, 2020
fix #307428: don't disable "remove selected range"
29 tasks
anatoly-os
added a commit
that referenced
this pull request
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/307428
A recent change simplified the handling
of the remove selected range command in the right-click menu,
but also disabled it for elements other than rests.
Unfortunately, it was never re-enabled, leaving you unable
to delete measures after right-clicking something other than a rest.
There is no good place to re-enable it as far as I know,
so I have changed this to simply not disable it.
Instead, I don't display it at all except for rests or notes.
This doesn't change the measure popup, only the object popup.
See #6008 for when this particular issue was introduced. But, I note that there have been reports of Ctrl+Delete mysteriously disabling itself, going back several years. So there may well be something else going on too. But this PR fixes a very recent regression.