Partially fix #294768: tremolos don't have cue size #6265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harmoniker1
changed the title
Harmoniker1
force-pushed
the
cue-size
branch
2 times, most recently
from
3ce34b5 to
6df6e65
Compare
This is because the `mag()` factor isn't taken into consideration. Along with multiplying `mag()` in some places, I also created a new member function `minHeight()` for `Tremolo` class to calculate the effective height of tremolo strokes, that is, the height the strokes spread across a given vertical line, without multiplying `spatium()`, to resolve an issue of stem length (a bit longer than intended when direction is down and has single-note tremolo on it) which is not obvious in normal size but obvious in cue size. Several places are already using this effective height, so a separate function for calculating it is really convenient to use.
|
vtest failures are intended. |
1 task
|
For some strange reason a couple mtests crash |
Comment on lines
+484
to
+489
|
|
||
| //--------------------------------------------------------- | ||
| // layout | ||
| //--------------------------------------------------------- | ||
|
|
||
| void Tremolo::layout() |
There was a problem hiding this comment.
Any reason you moved this whole function? This makes the diff larger, obscures what has actually changed, and reduces the benefit of git blame, all for no purpose.
There was a problem hiding this comment.
This is because I want to make the two functions for single-note and double-note tremolos respectively be adjacent, rather than having this main layout() function in the way.
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves: https://musescore.org/node/294768.
This is because the
mag()factor isn't taken into consideration.Along with multiplying
mag()in some places, I also created a new member functionminHeight()forTremoloclass to calculate the effective height of tremolo strokes, that is, the height the strokes spread across a given vertical line, without multiplyingspatium(), to resolve an issue of stem length (a bit longer than intended when direction is down and has single-note tremolo on it) which is not obvious in normal size but obvious in cue size. Several places are already using this effective height, so a separate function for calculating it is really convenient to use.Commit #2: (resolves https://musescore.org/en/node/286504#comment-1011220)
Before:
After: