Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial musicxml fixes 3.x #6256

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

lvinken
Copy link
Contributor

@lvinken lvinken commented Jun 24, 2020

Resolves:
https://musescore.org/en/node/305313
https://musescore.org/en/node/306725

Low risk small fixes improving MusicXML import/export

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@anatoly-os anatoly-os merged commit 1f310c1 into musescore:3.x Jun 24, 2020
@lvinken lvinken mentioned this pull request Jun 24, 2020
8 tasks
@lvinken lvinken deleted the trivial-musicxml-fixes-3.x branch September 21, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants