[MU3] Partial fix for #306911 #6255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
reset-dialog
branch
from
9cd4b4b to
b07cd7c
Compare
|
Not sure whether this PR should make it into 3.5.0, due to string freeze. It might go to 3.5.1 though. |
Jojo-Schmitz
force-pushed
the
reset-dialog
branch
from
b07cd7c to
8b01043
Compare
Spire42
reviewed
Jun 24, 2020
mscore/musescore.cpp
Outdated
| else { // either set to "Ask" or not at all | ||
| QMessageBox msgBox; | ||
| QCheckBox ask; | ||
| ask.setText(tr("Don't ask me again.")); | ||
| ask.setText(tr("Remember my choice and don't ask again.")); |
There was a problem hiding this comment.
The standard convention for checkbox text is not to have any punctuation at the end, so I would remove the “.”.
(I know that the “.” was already there prior to this PR, but it shouldn't have been, so we might as well take this opportunity to fix it.)
There was a problem hiding this comment.
fine by me, done
Jojo-Schmitz
force-pushed
the
reset-dialog
branch
from
8b01043 to
c684b52
Compare
30 tasks
|
Changing strings is up to 3.6 |
Jojo-Schmitz
force-pushed
the
reset-dialog
branch
from
c684b52 to
02976a8
Compare
74 tasks
Jojo-Schmitz
changed the title
* clarify the "don't ask again" * mention the current MuseScore version (that way the same dialog still works in MuseScore 4) * don't mark the score dirty if the reset is taken * fix a typo
Jojo-Schmitz
force-pushed
the
reset-dialog
branch
from
02976a8 to
001d9f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://musescore.org/en/node/306911
This PRs fixes:
works in MuseScore 4)
It does not resolve the core issue of showing a Save dialog on close of any imported score if no changes have been done to the score (other than the reset).
Its counterpart for master had been merged meanwhile