Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #305069: Chord symbols attached to fret diagrams don't play back #6218

Merged
merged 1 commit into from
Jun 20, 2020

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Jun 15, 2020

@MarcSabatella
Copy link
Contributor

Nice! I figured it would be something like that, but hadn't checked to see where this happens.

I wonder if it's worth having a function "hasHarmonyPlayback" or something like that so we don't have to always check like this? It could also conceivably return false if the preference is off, or if the play property is off. And, it could conceivably return true for fret diagrams that don't have a chord symbol attached, if we ever implement direct playback of the voicing from the fret diagram itself.

But that kind of decision might want to wait until we definitively decide how we want ther default to work for chord symbol playback. To me this is still an open question we need to resolve, and I guess I ay just need to propose and implement something.

@Jojo-Schmitz
Copy link
Contributor Author

Well, this method is used in 4 places, 2 of which just need to know whether or not there are harmonies and I'm not sure whether the other 2 really need the number.

@anatoly-os anatoly-os merged commit e3243fa into musescore:3.x Jun 20, 2020
@Jojo-Schmitz Jojo-Schmitz deleted the fretboard-harmony-playback branch June 20, 2020 11:33
anatoly-os added a commit that referenced this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants