Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #306502: Toolbar item states are incorrect after applying preferences #6185

Conversation

Spire42
Copy link
Contributor

@Spire42 Spire42 commented Jun 9, 2020

Resolves: #306502

Fixed some problems that caused the states of one or more toolbar items to become incorrect after the user went to Edit | Preferences and clicked OK.

Also renamed a pair of relevant getter/setter functions in the MuseScore class that were inconsistently and confusingly named.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

…nces

Fixed some problems that caused the states of one or more toolbar items to become incorrect after the user went to “Edit” | “Preferences” and clicked “OK”.

Also renamed a pair of relevant getter/setter functions in the “MuseScore” class that were inconsistently and confusingly named.
@Spire42 Spire42 mentioned this pull request Jun 9, 2020
12 tasks
@anatoly-os anatoly-os merged commit 22d9345 into musescore:3.x Jun 9, 2020
anatoly-os added a commit that referenced this pull request Jun 10, 2020
…incorrect-after-applying-preferences

Fix #306502: Toolbar item states are incorrect after applying preferences
anatoly-os added a commit that referenced this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants