fix #304959: fix clipping and scaling of Key Signatures palette in New Score wizard #6167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w Score wizard Ensures accounting for GUI scaling in PaletteListView and uses a different approach to prevent large gaps between palette cells (using setGridSize() call instead of setting negative spacing). This approach prevents clipping of some cells in that palette. Co-authored-by: Marc Sabatella <marc@outsideshore.com>
|
Someday I'll find out how you did that :-). Anyhow, I confirm these changes work for me too. But it would be useful to check on a few others systems since the problem itself was system/display-dependent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/304959
Ensures accounting for GUI scaling in PaletteListView and uses a
different approach to prevent large gaps between palette cells
(using setGridSize() call instead of setting negative spacing).
This approach prevents clipping of some cells in that palette.
Collaboratively developed in the Telegram chat discussion with @MarcSabatella so I put a co-authorsip in the commit :)