Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix# 306180: Adding notes to a tuplet now adds them with respect to t… #6153

Conversation

blackears
Copy link
Contributor

Resolves: https://musescore.org/en/node/306180

Adding notes to a tuplet in piano roll editor now adds them with respect to the tuplet's space.

Adding a method to Fraction to return the inverse.

Updating header comment in tuplet.h

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@blackears blackears mentioned this pull request Jun 1, 2020
12 tasks
@blackears blackears force-pushed the 306180-PRE-enter-tuplet-notes-in-tuplet-space branch from 7b7539e to 8b8b895 Compare June 1, 2020 18:20
…he tuplet's space.

Adding notes to a tuplet now adds them with respect to the tuplet's space.
@blackears blackears force-pushed the 306180-PRE-enter-tuplet-notes-in-tuplet-space branch from 8b8b895 to 5443daa Compare June 1, 2020 18:22
@anatoly-os
Copy link
Contributor

Let's postpone further improvements for the PRE to the MU 4. Please rebase this and other PRs onto master.

@blackears
Copy link
Contributor Author

Was talking with chat - they were saying that the UI is being rewritten and that the 3.x branch is pretty well a dead end at this point. So my changes cannot be made to the master branch because it is really just acting as a placeholder right now and is going to be completely replaced.

The four PRs I submitted work with the 3.x PRE and will provide some bugfixes and functionality. Since they cannot be applied to the master, would it still be possible to apply them to 3.x just to leave this branch in the best possible state?

@anatoly-os anatoly-os merged commit 0600345 into musescore:3.x Jun 22, 2020
anatoly-os added a commit that referenced this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants