fix #291522 : Double-click on drum palette produces wrong note when t…

[AntonioBL]

…ransposing instrument at top of score and concert pitch off

Resolves: https://musescore.org/en/node/291522

When the note was read from the drumset palette data, the first staff of the score was considered as the starting note staff for the note to be added, therefore, if this was a transposing instrument staff, the note pitch was adjusted by the transposing properties of such first staff by entering the if condition here

MuseScore/libmscore/note.cpp

Line 1338 in e925ba0

if (staff() && !staff()->isDrumStaff(e.tick()) && !e.pasteMode() && !MScore::testMode) {

• I signed CLA
• I made sure the code in the PR follows the coding rules
• I made sure the code compiles on my machine
• I made sure there are no unnecessary changes in the code
• I made sure the title of the PR reflects the core meaning of the issue you are solving
• I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
• I made sure the commit message title starts with "fix #424242:" if there is a related issue
• [N/A] I created the test (mtest, vtest, script test) to verify the changes I made

[AntonioBL]

I could not find a way to use the drum note enter palette to create a test script.

Note: Currently, by inserting drum notes with double clicks does not preserve those notes voice (e.g. bass drum is entered in voice 1 instead of 2). Is this a known bug?

[anatoly-os]

@AntonioBL The bug you mentioned is definitely not addressed one. Feel free to create the issue.