Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #305428 - TextLine doesn't cause a multi-measure break #6087

Merged
merged 1 commit into from
May 18, 2020
Merged

Fix #305428 - TextLine doesn't cause a multi-measure break #6087

merged 1 commit into from
May 18, 2020

Conversation

njvdberg
Copy link
Contributor

Resolves: https://musescore.org/en/node/305428

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@Jojo-Schmitz
Copy link
Contributor

Travis CI mtest fail, see https://travis-ci.org/github/musescore/MuseScore/jobs/686958958#L4302-L4328

Spire42
Spire42 reviewed May 14, 2020
View reviewed changes
libmscore/layout.cpp Outdated Show resolved Hide resolved
@njvdberg njvdberg force-pushed the issue-305428-textline-mmrest branch from 76f5f70 to c618e35 Compare May 14, 2020 16:25
@njvdberg
Copy link
Contributor Author

Corrected the reference, mtest is now running fine locally.

@anatoly-os anatoly-os merged commit e135b6c into musescore:3.x May 18, 2020
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request May 18, 2020
Closed
29 tasks
anatoly-os added a commit that referenced this pull request May 20, 2020
@anatoly-os
Merge pull request #6087 from njvdberg/issue-305428-textline-mmrest
ca7e46d 
Fix #305428 - TextLine doesn't cause a multi-measure break
@njvdberg njvdberg deleted the issue-305428-textline-mmrest branch May 22, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spire42 Spire42 Spire42 left review comments

@Jojo-Schmitz Jojo-Schmitz Jojo-Schmitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@njvdberg @Jojo-Schmitz @Spire42 @anatoly-os