Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #283964 - Linked parts for single voices don't work #6049

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

njvdberg
Copy link
Contributor

@njvdberg njvdberg commented May 6, 2020

Resolves: https://musescore.org/en/node/283964

Corrects recognition of linked staves with a part and linked staves over excerpts.

Score::undoAddCR() will find all linked staves for the passed ChordRest and iterates over all these staves and decides what to do. The root cause of this issue was this algorithm didn't clearly distinguish between the two different kind of linked staves:

  • 1 Linked staves within a part

  • 2 Linked staves between master score and scores on excerpt.
    This PR now handles creating a ChordRest for the following cases:

  • 1 On non-linked staff at the master score.

  • 2 On a staff linked, via an excerpt, to another score on another part.

  • 3 On a staff linked, via an excerpt, to another score on another part using the voice-to-part feature.

  • 4 On a staff linked to another staff on the same score ("linked staves" in the Parts dialog).

  • 5 On a staff linked to another staff on the same score and to another part.

  • 6 On a staff linked to another staff on the same score and to another part using the voice-to-part.
    All 6 cases are tested by creating a ChordRest on the master score and all, if applicable, on any of the linked staves.

Corrects recognition of linked staves with a part and linked staves over excerpts.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@njvdberg njvdberg mentioned this pull request May 6, 2020
12 tasks
Corrects recognistion of linked staves with a part and linked staves over
excerpts.
@njvdberg
Copy link
Contributor Author

This PR is related to, but not the same as PR #6116. Both are solving another issues with linked staffs.

@njvdberg njvdberg force-pushed the issue-283964-linked-part branch from 94ce953 to a35b1ef Compare May 25, 2020 10:30
@anatoly-os anatoly-os merged commit 5011d47 into musescore:3.x Jun 2, 2020
@njvdberg njvdberg deleted the issue-283964-linked-part branch June 6, 2020 17:45
mattmcclinch added a commit to mattmcclinch/MuseScore that referenced this pull request Jun 21, 2020
Resolves: https://musescore.org/en/node/306917.

Apply the same method from https:://github.com/musescore/pull/6049 in undoAddElement() for determining the tracks in which to place new elements.
mattmcclinch added a commit to mattmcclinch/MuseScore that referenced this pull request Jun 21, 2020
Resolves: https://musescore.org/en/node/306917.

Apply the same method from https:://github.com/musescore/pull/6049 in undoAddElement() for determining the tracks in which to place new elements.
anatoly-os added a commit that referenced this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants