-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #65241: add property and style for position of multimeasure rest numbers #5811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecstrema
reviewed
Mar 13, 2020
It could be worth separating MM rests into 2 elements: one for the number and one for the line. Needs some investigation... |
Harmoniker1
reviewed
Mar 14, 2020
ecstrema
reviewed
Mar 15, 2020
9af9599
to
cced1ff
Compare
ecstrema
reviewed
Mar 15, 2020
ecstrema
reviewed
Mar 15, 2020
ecstrema
reviewed
Mar 15, 2020
ecstrema
reviewed
Mar 15, 2020
cced1ff
to
8267c74
Compare
Rebase needed. |
vpereverzev
requested changes
Apr 22, 2020
ecstrema
reviewed
Apr 22, 2020
4e94b56
to
426055a
Compare
426055a
to
52b7c84
Compare
I believe all review comments have been addressed. |
82efb00
to
9af96a6
Compare
vpereverzev
approved these changes
Apr 29, 2020
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/65241
Adds an additional Inspector property for the vertical position of multimeasure rest numbers, and a corresponding linked style parameter.