Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #65241: add property and style for position of multimeasure rest numbers #5811

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

IsaacWeiss
Copy link
Contributor

@IsaacWeiss IsaacWeiss commented Mar 13, 2020

Resolves: https://musescore.org/en/node/65241

Adds an additional Inspector property for the vertical position of multimeasure rest numbers, and a corresponding linked style parameter.

Capture

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@ecstrema
Copy link
Contributor

Yay! What would be useful (and not difficult to implement I believe) would be the interval based measure numbers.
image
I believe that there is an issue associated with it, but I can't find it.

libmscore/rest.h Outdated Show resolved Hide resolved
libmscore/rest.cpp Outdated Show resolved Hide resolved
@ecstrema
Copy link
Contributor

It could be worth separating MM rests into 2 elements: one for the number and one for the line. Needs some investigation...

libmscore/rest.cpp Outdated Show resolved Hide resolved
@IsaacWeiss
Copy link
Contributor Author

Yay! What would be useful (and not difficult to implement I believe) would be the interval based measure numbers.
image
I believe that there is an issue associated with it, but I can't find it.

That would be part of a Google Summer of Code Project I am considering. :-)

libmscore/rest.cpp Outdated Show resolved Hide resolved
@IsaacWeiss IsaacWeiss force-pushed the 65241-mmrest-numbers branch from 9af9599 to cced1ff Compare March 15, 2020 18:47
libmscore/rest.cpp Outdated Show resolved Hide resolved
@IsaacWeiss IsaacWeiss force-pushed the 65241-mmrest-numbers branch from cced1ff to 8267c74 Compare March 16, 2020 02:26
@RobFog
Copy link

RobFog commented Apr 21, 2020

Rebase needed.

libmscore/property.cpp Outdated Show resolved Hide resolved
libmscore/rest.cpp Outdated Show resolved Hide resolved
libmscore/rest.cpp Outdated Show resolved Hide resolved
libmscore/rest.h Outdated Show resolved Hide resolved
libmscore/rest.h Outdated Show resolved Hide resolved
mscore/editstyle.ui Outdated Show resolved Hide resolved
libmscore/rest.cpp Outdated Show resolved Hide resolved
@IsaacWeiss IsaacWeiss force-pushed the 65241-mmrest-numbers branch 3 times, most recently from 4e94b56 to 426055a Compare April 28, 2020 16:51
@IsaacWeiss IsaacWeiss force-pushed the 65241-mmrest-numbers branch from 426055a to 52b7c84 Compare April 28, 2020 16:59
@IsaacWeiss
Copy link
Contributor Author

IsaacWeiss commented Apr 28, 2020

Added the collision avoidance, as seen in this GIF:
Capture

@IsaacWeiss
Copy link
Contributor Author

I believe all review comments have been addressed.

@IsaacWeiss IsaacWeiss force-pushed the 65241-mmrest-numbers branch from 82efb00 to 9af96a6 Compare April 29, 2020 02:08
@anatoly-os anatoly-os requested a review from vpereverzev April 29, 2020 11:58
@anatoly-os anatoly-os merged commit 6601f4e into musescore:master Apr 29, 2020
@IsaacWeiss IsaacWeiss deleted the 65241-mmrest-numbers branch May 12, 2020 03:24
@ecstrema ecstrema mentioned this pull request May 21, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants