Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #292393 : Pasting tremolo between dotted notes leads to wrong rhythm #5774

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

AntonioBL
Copy link
Contributor

Resolves: https://musescore.org/en/node/292393

Pasting of two-note tremolos was accidentally broken by commit 4c6f877 since their actual duration and duration type are different.
This PR adds a correction factor so that two-note tremolo pasting is not considered as a partial note paste.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@AntonioBL AntonioBL changed the base branch from master to 3.x May 6, 2020 19:31
@AntonioBL AntonioBL mentioned this pull request May 6, 2020
12 tasks
@anatoly-os anatoly-os merged commit f0b24ae into musescore:3.x Jun 2, 2020
anatoly-os added a commit that referenced this pull request Aug 20, 2020
@AntonioBL AntonioBL deleted the tremolopaste branch October 26, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants