fix #301834: crash when changing local time signature to another one with same duration #5773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harmoniker1
force-pushed
the
local-timesig-crash
branch
from
33d4847 to
d52c012
Compare
igorkorsukov
reviewed
Apr 1, 2020
Harmoniker1
force-pushed
the
local-timesig-crash
branch
from
d52c012 to
8b29278
Compare
…with same duration This is because it doesn't check whether the time signature is local or not, so it always goes to every staff and trys to find a time signature segment, causing `nullptr`.
Harmoniker1
force-pushed
the
local-timesig-crash
branch
from
8b29278 to
9d94c33
Compare
igorkorsukov
approved these changes
Apr 13, 2020
12 tasks
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/node/301834.
This is because it doesn't check whether the time signature is local or not, so it always goes to every staff and trys to find a time signature segment, causing
nullptr.