Fix GH#26494: MusicXML Import - Beams don't have their color imported #26495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Jojo-Schmitz
force-pushed
the
xml/import-beam-color
branch
2 times, most recently
from
e423c14 to
e7b9800
Compare
Jojo-Schmitz
force-pushed
the
xml/import-beam-color
branch
3 times, most recently
from
2326e00 to
00b3d50
Compare
Jojo-Schmitz
force-pushed
the
xml/import-beam-color
branch
from
00b3d50 to
35d025f
Compare
miiizen
approved these changes
Feb 14, 2025
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2025
'Backport' of musescore#26495 Current restriction: doesn't work for grace note beams Further restriction: if in the MusicXML different colors are set for different strokes of a beam, like for 16ths' beams' upper and lower stroke, the last color wins, MuseScore does not allow for this, it colors the entire beam, not single strokes of it.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2025
Backport of musescore#26495, 2nd commit
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2025
Backport of musescore#26495, 2nd commit
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2025
'Backport' of musescore#26495, 1st commit Current restriction: doesn't work for grace note beams Further restriction: if in the MusicXML different colors are set for different strokes of a beam, like for 16ths' beams' upper and lower stroke, the last color wins, MuseScore does not allow for this, it colors the entire beam, not single strokes of it.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2025
'Backport' of musescore#26495, 1st commit Current restriction: doesn't work for grace note beams Further restriction: if in the MusicXML different colors are set for different strokes of a beam, like for 16ths' beams' upper and lower stroke, the last color wins, MuseScore does not allow for this, it colors the entire beam, not single strokes of it.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2025
…rted Backport of musescore#26495, 2nd commit
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2025
…rted Backport of musescore#26495, 2nd commit
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2025
…rted Backport of musescore#26495, 2nd commit
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2025
Backport of musescore#26495, 2nd commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26494
Current restriction: doesn't work for grace note beams
Further restriction: if in the MusicXML different colors are set for different strokes of a beam, like for 16ths' beams' upper and lower stroke, the last color wins, MuseScore does not allow for this, it colors the entire beam, not single strokes of it.
Also added color import for arpeggios and extended testColor.xml to test both