Fix (translatable) texts in Edit style dialog #26422
Open
+146
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jojo-Schmitz
commented
Feb 10, 2025
•
Jojo-Schmitz
commented
- Placement -> Position
- Position abobe/below -> Offset above/below
- Add % suffix, move 'suffix' " / 4" and " measure" to after the spinbox and changing to "quarter" resp. "measure(s)
- Fix a reset button's accessibility text and add a missing tooltip to it
FrancRos31
reviewed
Feb 10, 2025
| @@ -12333,6 +12336,9 @@ text x-height):</string> | |||
| <property name="keyboardTracking"> | |||
| <bool>false</bool> | |||
| </property> | |||
| <property name="suffix"> | |||
| <string>%</string> | |||
| </property> | |||
There was a problem hiding this comment.
Yes, used here:
the suffix
There was a problem hiding this comment.
Ah, thanks for the reminder.
Will keep an eye on it and change to "notr=true" if and when needed (i.e. a decicsion between those 2 PRs has been made), or add it to #26383 if this PR here gets merged earlier
src/notation/qml/MuseScore/NotationScene/internal/EditStyle/ClefKeyTimeSigPage.qml
Outdated
Show resolved
Hide resolved
Jojo-Schmitz
force-pushed
the
trans-texts
branch
2 times, most recently
from
5dde3fd to
9167ac6
Compare
Jojo-Schmitz
commented
Feb 11, 2025
| <property name="text"> | ||
| <string notr="true"/> | ||
| <string>/ 4</string> |
There was a problem hiding this comment.
All the above stuff moves the suffixes " / 4" and " measure" to after their spinboxes and this avoids translatable strings with leading spaces. Also changing them to "quarter(s)" and "measure(s)". New look:
Jojo-Schmitz
force-pushed
the
trans-texts
branch
4 times, most recently
from
5c20666 to
bf752e8
Compare
Jojo-Schmitz
force-pushed
the
trans-texts
branch
2 times, most recently
from
12c1e7a to
b56e08e
Compare
Jojo-Schmitz
commented
Feb 13, 2025
| TranslatableString("action", "&Note anchored line"), | ||
| TranslatableString("action", "Add note anchored line") | ||
| TranslatableString("action", "&Note-anchored line"), | ||
| TranslatableString("action", "Add note-anchored line") |
This was referenced Feb 13, 2025
Jojo-Schmitz
force-pushed
the
trans-texts
branch
from
b56e08e to
59280e7
Compare
* Placement -> Position * Position abobe/below -> Offset above/below * Add % suffix, move 'suffix' " / 4" and " measure" to after the spinbox and changing to "quarter" resp. "measure(s) * Fix a reset button's accessibility text and add a missing tooltip to it
Jojo-Schmitz
force-pushed
the
trans-texts
branch
from
59280e7 to
20eed9d
Compare
Jojo-Schmitz
changed the title
Jojo-Schmitz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.