Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #26208 (Dynamics): [Musicxml Export] - End-bar items lost #26388

Merged

Conversation

pacebes
Copy link
Contributor

@pacebes pacebes commented Feb 7, 2025

Resolves: #26208 (Dynamics)

This PR exports dynamic elements (p, pp, fff...) when they are linked to a TimeTickType segment

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@pacebes
Copy link
Contributor Author

pacebes commented Feb 7, 2025

I have attached the tests files (mscx original and .musicxml exported files):
Score_26208_test1.zip

@pacebes pacebes force-pushed the 26208-MusicXMLExportEndbarItemsLost_Dynamics branch from 7f81834 to 04016b6 Compare February 12, 2025 11:03
@miiizen miiizen merged commit 0c8964c into musescore:master Feb 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Musicxml Export] - End-bar items lost due to various fraction offsets
2 participants