Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Pedal playback not working for "pedal change" #12869

Closed
MarcSabatella opened this issue Aug 15, 2022 · 7 comments · Fixed by #13759 or #18766
Closed

[MU4 Issue] Pedal playback not working for "pedal change" #12869

MarcSabatella opened this issue Aug 15, 2022 · 7 comments · Fixed by #13759 or #18766
Assignees
Labels
P1 Priority: High
Milestone

Comments

@MarcSabatella
Copy link
Contributor

MarcSabatella commented Aug 15, 2022

Describe the bug
The standard "pedal change" marking ___/\___ does not work; it lifts the pedal off but does not return it to the on position

To Reproduce
Steps to reproduce the behavior:

  1. Piano score
  2. Add four quarter notes C D E D to first measure and again to the second
  3. Add a |___/ pedal marking from the first C to the second
  4. Add a \___| pedal marking from the second C to the end of the measure
  5. Play

Result*
Pedal lifts in bar 2 but does not re-engage

Expected behavior
Second measure should have pedal engaged just like the first

Screenshots
image

Platform information

  • OS: Linux

Additional context
The old-style Ped___* markings work fine because they don't overlap. The issue seems to only occur on the pedal changes - the places where the end of one pedal coincides the the start of the next to create the characteristic pedal change ___/\___. If I were to guess, I'd say the pedal off and on messages are simply being sent in the wrong order.

@MarcSabatella
Copy link
Contributor Author

MarcSabatella commented Sep 12, 2022

Bump - could this get prioritized? @Tantacrul - easily reproducible in any score using pedal change.

@Tantacrul Tantacrul added the P1 Priority: High label Sep 13, 2022
@Tantacrul
Copy link
Contributor

Yeah, I've been noticing this myself too.

@vpereverzev vpereverzev added this to the Sprint 74 milestone Sep 26, 2022
@MarcSabatella
Copy link
Contributor Author

FWIW, this is now the only significant issue remaining with "Reunion" - https://musescore.com/user/2975/scores/39069

@Tantacrul
Copy link
Contributor

Just had a call with Vasily an hour ago, where we placed this issue in our top 3. Won't be much longer

vpereverzev added a commit to vpereverzev/MuseScore that referenced this issue Oct 14, 2022
vpereverzev added a commit to vpereverzev/MuseScore that referenced this issue Oct 14, 2022
vpereverzev added a commit to vpereverzev/MuseScore that referenced this issue Oct 14, 2022
vpereverzev added a commit to vpereverzev/MuseScore that referenced this issue Oct 14, 2022
vpereverzev added a commit to vpereverzev/MuseScore that referenced this issue Oct 14, 2022
vpereverzev added a commit to vpereverzev/MuseScore that referenced this issue Oct 14, 2022
vpereverzev added a commit to vpereverzev/MuseScore that referenced this issue Oct 14, 2022
vpereverzev added a commit to vpereverzev/MuseScore that referenced this issue Oct 17, 2022
vpereverzev added a commit that referenced this issue Oct 18, 2022
@FireController1847
Copy link

FireController1847 commented Jan 2, 2023

I'm still having issues with pedal changes on this front, particularly when migrating from old versions of MuseScore. Notes are cut off early, general playback with MS Sounds is unreliable and unclean. Every once in a while a note goes max velocity as well. I can send example files but the songs are copyrighted so I'll have to email them or send them through other means.

Just installed MuseScore 4 as of writing, using v1.0.0.

bluebear94 added a commit to bluebear94/MuseScore that referenced this issue Jul 22, 2023
This immediately fixes musescore#16757, which occurred when a chord right
after the end of a pedal line was counted as intersecting its
duration.

This commit also reverts the subtraction by `Constants::DIVISION / 4`
for the duration of a pedal line ending in an angled hook. This
subtraction was introduced in order to fix musescore#12869, but it has caused
other issues such as musescore#16757 and is probably unneeded given the
fix to `isPlayable`.
bluebear94 added a commit to bluebear94/MuseScore that referenced this issue Jul 22, 2023
This immediately fixes musescore#16757, which occurred when a chord right
after the end of a pedal line was counted as intersecting its
duration.

This commit also reverts the subtraction by `Constants::DIVISION / 4`
for the duration of a pedal line ending in an angled hook. This
subtraction was introduced in order to fix musescore#12869, but it has caused
other issues such as musescore#16001 and is probably unneeded given the
fix to `isPlayable`.
bluebear94 added a commit to bluebear94/MuseScore that referenced this issue Jul 24, 2023
This immediately fixes musescore#16757, which occurred when a chord right
after the end of a pedal line was counted as intersecting its
duration.

This commit also reverts the subtraction by `Constants::DIVISION / 4`
for the duration of a pedal line ending in an angled hook. This
subtraction was introduced in order to fix musescore#12869, but it has caused
other issues such as musescore#16001 and is probably unneeded given the
fix to `isPlayable`.
bluebear94 added a commit to bluebear94/MuseScore that referenced this issue Sep 29, 2023
This immediately fixes musescore#16757, which occurred when a chord right
after the end of a pedal line was counted as intersecting its
duration.

This commit also reverts the subtraction by `Constants::DIVISION / 4`
for the duration of a pedal line ending in an angled hook. This
subtraction was introduced in order to fix musescore#12869, but it has caused
other issues such as musescore#16001 and is probably unneeded given the
fix to `isPlayable`.
cbjeukendrup pushed a commit to cbjeukendrup/MuseScore that referenced this issue Sep 30, 2023
This immediately fixes musescore#16757, which occurred when a chord right
after the end of a pedal line was counted as intersecting its
duration.

This commit also reverts the subtraction by `Constants::DIVISION / 4`
for the duration of a pedal line ending in an angled hook. This
subtraction was introduced in order to fix musescore#12869, but it has caused
other issues such as musescore#16001 and is probably unneeded given the
fix to `isPlayable`.
@Ander3232
Copy link

Any progress with this? It seems like a pretty basic thing. And how do you include the "Ped." text symbol at the beginning of the extended line?

@MarcSabatella
Copy link
Contributor Author

The issue reported here was fixed a year ago, which is why this issue is marked “closed”. If you are having issues using a current version of MuseScore, that is probably something different. Please open a new thread and ZIP and attach the score you are having trouble with and give precise steps to reproduce the problem.

To add text to a line, or change other line properties such as hooks, use the Properties panel. See the existing Ped line to see the syntax for that special symbol. If you have further questions about how to use MuseScore, please use the support forum on MuseScore.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High
Projects
None yet
6 participants