-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Resolved a WIX compilation crash for 32/64 versions
- Loading branch information
1 parent
f99dd7a
commit daa5fb7
Showing
1 changed file
with
1 addition
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daa5fb7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts #6532, doesn't it?
But for Windows only, not for macOS and Linux.
daa5fb7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, only for Windows. It's turned out that WIX can't recognize ".mscz," and ".mscx," for some reason.
daa5fb7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
win32/WIX/main.wixobj
win32/WIX/main.wxs
daa5fb7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe those commas need to get escaped in some way?
daa5fb7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we need something different, maybe just like
.mscxbac
daa5fb7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I do manually register ' *.mscz,' I get the following 8 registry keys (and it works too):
Maybe this gives a hint at how to properly add them?
daa5fb7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it could work if you write it manually. There is only problem with WIX parser, for some reason it can't recognize the difference between "mscz" and "mscz," and this issue leads to crash during the build
daa5fb7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess it that is used the comma as a field separator in its syntax. And maybe there is a way to hide it from that, via single ticks or backslash for example?
daa5fb7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever we do with it, we'd need to do it to the 3.x branch too (I'll amend my corresponding PR for master accordingly)