-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal utoipa example with file upload #85
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 11 11
Lines 371 371
=======================================
Hits 358 358
Misses 13 13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mattdavis90, thanks for the contribution! Maybe we could briefly mention this example in src/lib.rs
? So users know it exists.
I also see the CI lint failing so I would suggest you install the pre-commit hooks to make your life easier. |
b4516f9
to
cbe46dd
Compare
I went back and fixed the git commit message to be semantic and I've run through pre-commit - I totally missed that in the repo. I've added documentation - hopefully it reads ok and is somewhat in keeping with what you already had. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just left a small comment :)
I've updated the docs to be a link and I think I fixed the issues with the conflicting versions of |
If you want you could also put whatever extra dep in dev-dependencies in the root Cargo.toml instead of using an extra manifest, maybe it will fix the issue? |
I wasn't sure if it was reasonable to make devs install all dependencies for examples. Happy to go with your preference :) |
Never mind @mattdavis90 the problem is independent of your PR, will get it fixed. |
a043fc4
to
fbc9d43
Compare
As per #82 I've added a minimal example of using
axum_typed_multipart
withutoipa
The example is self-contained and I included a
Cargo.toml
because it requires additional dependencies. I haven't included a README as the code is hopefully reasonably easy to follow. On starting the web server arapidoc
user interface will describe the API endpoint and present a sample form that can be filled.Thanks